remove two fields from goto-binary function format #3113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kroening
requested review from
peterschrammel,
pkesseli,
smowton and
tautschnig
as code owners
tautschnig
requested changes
Oct 8, 2018
| @@ -97,11 +97,9 @@ bool write_goto_binary_v4( | |||
| const goto_programt::instructiont &instruction = *i_it; | |||
|
|
|||
| irepconverter.reference_convert(instruction.code, out); | |||
| irepconverter.write_string_ref(out, instruction.function); | |||
There was a problem hiding this comment.
I don't think we are there just yet: this should only be done once we have sanity checks of goto programs in place, and those ensure that fct.first == instruction.function, which I doubt truly holds at the moment.
tautschnig
changed the title
tautschnig
added a commit
that referenced
this pull request
Feb 4, 2019
remove goto_programt::instructiont::function member [blocks: #3113]
tautschnig
force-pushed
the
goto-binary-v5
branch
from
fdc819f to
63db047
Compare
tautschnig
changed the title
tautschnig
approved these changes
Feb 4, 2019
tautschnig
force-pushed
the
goto-binary-v5
branch
2 times, most recently
from
a180b04 to
0d91a71
Compare
This removes the name of the function in every instruction (it's known from the function that's being read), and an unused field. This also increases version number of goto binary format to 5.
tautschnig
force-pushed
the
goto-binary-v5
branch
from
0d91a71 to
3a84988
Compare
allredj
reviewed
Feb 4, 2019
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 3a84988).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/99687290
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the name of the function in every instruction (it's known from
the function that's being read), and an unused field. This also increases
version number of goto binary format to 5.